-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieve viz url #1907
Retrieve viz url #1907
Conversation
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
…iz-url Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
src/components/shareable-url-modal/published-view/published-view.js
Outdated
Show resolved
Hide resolved
src/components/shareable-url-modal/published-view/published-view.js
Outdated
Show resolved
Hide resolved
Hi @Huongg , Apologies for the delay in reviewing the PR. Most of the code looks good. I had a first pass and left few comments and questions. Please have a look. Thank you |
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Co-authored-by: Ravi Kumar Pilla <[email protected]> Signed-off-by: Huong Nguyen <[email protected]>
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Hi @Huongg , Thanks for addressing all the comments. There are some minor observations and I would like to know what the team thinks @stephkaiser @jitu5 -
Let me know if you need more info. Thank you |
hey so for point 1 and 2, it has been a behaviour of the form, if we think this is not right then we can create a separate issue for it. And for point 3, when you're in the form, it does not read from the localStorage anymore so when you change to a different platform, it wont be re-populated |
Signed-off-by: huongg <[email protected]>
FYI: link to the bug report for @ravi-kumar-pilla's comment 1 and 2: #1936 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Huongg ... looks great 💯
Signed-off-by: huongg <[email protected]>
Signed-off-by: huongg <[email protected]>
Description
Fixes #1851
Design is here
Development notes
QA notes
You can test the UI using Gitpod. I've implemented the logic prior to the check that validates whether the submitted platform is valid or not. As a result, you can use any fabricated names and URLs, the system will display an error message.
Checklist
RELEASE.md
file