Feat/slicing kedro viz #1872
Closed
Feat/slicing kedro viz #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rashidakanchwala <[email protected]>
…/kedro-viz into feat/slicing-kedro-viz
tynandebold
reviewed
Apr 24, 2024
Comment on lines
+14
to
+22
| const getEdges = createSelector( | ||
| [getEdgeIDs, getEdgeSources, getEdgeTargets], | ||
| (edgeIDs, edgeSources, edgeTargets) => | ||
| edgeIDs.map((id) => ({ | ||
| id, | ||
| source: edgeSources[id], | ||
| target: edgeTargets[id], | ||
| })) | ||
| ); |
There was a problem hiding this comment.
Is there any reason this logic can't live within the getEdgesByNode selector? It doesn't look like you're using it anywhere else.
| * @returns {Object} An object containing edges mapped by source and target nodes. | ||
| */ | ||
|
|
||
| export const getEdgesByNode = createSelector([getEdges], (edges) => { |
There was a problem hiding this comment.
Don't think you need to export this, do you?
src/selectors/filtered-pipeline.js
Outdated
Comment on lines
102
to
104
| filteredNodeIDs = linkedNodesBetween; | ||
|
|
||
| return filteredNodeIDs; |
There was a problem hiding this comment.
Do you need to reassign it here?
Suggested change
| filteredNodeIDs = linkedNodesBetween; | |
| return filteredNodeIDs; | |
| return linkedNodesBetween; |
Signed-off-by: huongg <[email protected]>
|
I am closing this PR but leaving the branch for @Huongg to work from it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Experimentation on filtering pipelines by slicing them the way kedro does.
Development notes
QA notes
Checklist
RELEASE.mdfile