-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Directory Selection for Server Startup #1741
Conversation
* Add link to open in new tab * add test and lint Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com> * Update RELEASE.md Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com> --------- Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com> Signed-off-by: Elias Santana <eliasvssantana@gmail.com>
Signed-off-by: Elias Santana <eliasvssantana@gmail.com>
e568b15
to
6733614
Compare
…kedro-viz into feature/set-directory
Thank you for your contribution. We apologise for the delay in responding; we're currently in a release sprint preparing to launch significant features. Once the release is complete, we'll review your submission and provide support with tests. |
@santana98 Could you detail a bit more what workflow do you have in mind? I suppose you have a "global" or "unique" Kedro-Viz installation and then you'd like to use that installation for different Kedro projects? |
@astrojuanlu A platform based on JupyterHub that provides users with a JupyterLab, like Kedro-Viz requires a port to start the server, this responsibility would be abstracted from the end-user, with the lab itself managing it, ensuring the correct proxy with the Hub and other dependencies. In this scenario, it's beneficial to enable users to specify the location of the Kedro project they wish to interact with in Kedro-Viz. This is because the application starts internally from the Lab, which operates from a completely different path than the Kedro project. |
@santana98 thanks for the context. If I understand correctly, Kedro Viz and the target Kedro project would still live in the same Python environment and therefore share the same dependencies, correct? |
@astrojuanlu |
@santana98 - i wasn't able to work off this PR to fix the lint and tests so I created a new PR based on your work. Can you have a look at it, and let me know if it's ok? #1792 |
@santana98 -Thank you for your ticket submission. After delving into the matter more thoroughly, we've encountered an issue with merging it presently. The core of the problem lies in the fact that kedro-viz is a kedro-plugin, and the kedro-viz CLI calls upon kedro CLI. This realisation surfaced during our deeper investigation of your ticket. |
@rashidakanchwala did we open a follow-up issue to take this use case into account? |
nope I have asked Santana but he hasn't yet since it's a Kedro Framework thing, would you like to raise this on Kedro Framework if you think it makes sense. |
Hello, everyone! I apologize for the delay in responding. I've been working on other topics in the past few weeks. @rashidakanchwala, I've tested it here, and PR #1792 worked as expected!! Thank you for your support.
The next suggested step would be to propose the option to select the "project-path" within the Kedro project itself, correct? This way, they can enable this option within the framework, and then we can simply pass the parameter through the kedro-viz call. |
@santana98 Yes! Please open a new discussion https://github.com/kedro-org/kedro/discussions/ |
Description
Hello!
This pull request aims to introduce a feature that allows users to select the directory from which the server will launch. With this enhancement, users will be able to switch between projects more seamlessly.
Development notes
The addition of the "project_path" argument now enables users to specify the path of the Kedro project.
QA notes
The concept behind this implementation is to keep it simple, providing users with the option to choose whether or not to specify a directory. If no value is provided, the current behavior will be preserved.
I'm seeking assistance from the community to improve test coverage. 🙏
Checklist
RELEASE.md
file