Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flowchart zoom: minimum scale fix on initial load #1687

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Flowchart zoom: minimum scale fix on initial load #1687

merged 4 commits into from
Dec 19, 2023

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented Dec 18, 2023

Description

Fix for initial load in flowchart where some objects are cut out.

QA notes

Test it with "Expand all modular pipelines" options turned on in Settings modal.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@jitu5 jitu5 requested a review from tynandebold as a code owner December 18, 2023 21:10
@jitu5 jitu5 self-assigned this Dec 18, 2023
@jitu5 jitu5 added the Javascript Pull requests that update Javascript code label Dec 18, 2023
ravi-kumar-pilla
ravi-kumar-pilla approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you 👍

@jitu5 jitu5 merged commit a25cff0 into main Dec 19, 2023
2 checks passed
@jitu5 jitu5 deleted the fix/mini_scale branch December 19, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynandebold tynandebold tynandebold approved these changes

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@ravi-kumar-pilla ravi-kumar-pilla ravi-kumar-pilla approved these changes

Assignees

@jitu5 jitu5

Labels
Javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jitu5 @tynandebold @rashidakanchwala @ravi-kumar-pilla