Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shareable viz issue with dataclass refactor #1640

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

ravi-kumar-pilla
Copy link
Contributor

Description

This is a quick fix for the issue with shareable viz due to dataclass refactor

Development notes

  • Exclude Node object from metadata class as it is not json serializable

QA notes

  • Test shareable viz
  • All test cases must pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: ravi-kumar-pilla <[email protected]>
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's great! let's merge it after fixing the e2e-tests

@ravi-kumar-pilla ravi-kumar-pilla merged commit b8fbc4b into main Nov 15, 2023
1 check passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the fix/refactor-dataclass-shareable branch November 15, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants