Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Pages 404 on demo site routes #2050

Closed
ravi-kumar-pilla opened this issue Aug 21, 2024 · 1 comment · Fixed by #2051
Closed

Fix GitHub Pages 404 on demo site routes #2050

ravi-kumar-pilla opened this issue Aug 21, 2024 · 1 comment · Fixed by #2051
Labels
Issue: Bug Report Javascript Pull requests that update Javascript code

Comments

@ravi-kumar-pilla
Copy link
Contributor

Description:

Accessing the URL - https://demo.kedro.org/experiment-tracking directly in the browser leads in 404

This is a deployment bug and also blocks PRs with CI docs build failure - https://readthedocs.org/projects/kedro-viz/builds/25360375/

Context:

GitHub Pages doesn’t support routers that use the HTML5 pushState history API under the hood (for example, React Router using browserHistory). This is because when there is a fresh page load for a url like http://user.github.io/todomvc/todos/42, where /todos/42 is a frontend route, the GitHub Pages server returns 404 because it knows nothing of /todos/42.

Possible solution:

More information and possible solutions are mentioned here - https://create-react-app.dev/docs/deployment/#github-pages

cc: @rashidakanchwala

@ravi-kumar-pilla ravi-kumar-pilla converted this from a draft issue Aug 21, 2024
@ravi-kumar-pilla ravi-kumar-pilla added Issue: Bug Report Javascript Pull requests that update Javascript code labels Aug 21, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Kedro-Viz Aug 21, 2024
@jitu5 jitu5 reopened this Aug 21, 2024
@ravi-kumar-pilla
Copy link
Contributor Author

closing this infavor of #2048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report Javascript Pull requests that update Javascript code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants