Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Kedro-viz telemetry tracking in the codebase #1900

Closed
1 task
rashidakanchwala opened this issue May 13, 2024 · 7 comments
Closed
1 task

Improve Kedro-viz telemetry tracking in the codebase #1900

rashidakanchwala opened this issue May 13, 2024 · 7 comments

Comments

@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented May 13, 2024

Description

The Kedro-viz telemetry numbers seem very low. This ticket is to revisit telemetry and ensure that tracking is accurate and correct information is being recorded.

Update - Kedro-Viz heap tracking works as expected. However there were number of interactions that were out of date and some new ones that we weren't tracking. We have fixed that now in #1995. Follow up ticket to this is #1999.

Context

Why is this change important to you? How would you use it? How can it benefit other users?

Possible Implementation

(Optional) Suggest an idea for implementing the addition or change.

Possible Alternatives

(Optional) Describe any alternative solutions or features you've considered.

Checklist

  • Include labels so that we can categorise your feature request
@rashidakanchwala rashidakanchwala moved this to Backlog in Kedro-Viz May 13, 2024
@rashidakanchwala rashidakanchwala self-assigned this May 13, 2024
@rashidakanchwala rashidakanchwala moved this from Backlog to Todo in Kedro-Viz May 13, 2024
@jitu5 jitu5 moved this from Todo to Backlog in Kedro-Viz Jun 10, 2024
@astrojuanlu astrojuanlu moved this from Backlog to Todo in Kedro-Viz Jun 10, 2024
@rashidakanchwala rashidakanchwala moved this from Todo to In Progress in Kedro-Viz Jul 5, 2024
@astrojuanlu
Copy link
Member

Addressed in #1995

@github-project-automation github-project-automation bot moved this from In Progress to Done in Kedro-Viz Jul 24, 2024
@yetudada
Copy link
Contributor

I have a query about this; I assumed there were two issues with tracking telemetry on Kedro-Viz:

  1. We’re not sure if telemetry is properly activated when users have opted in for tracking (the old way)
  2. There’s a mess with how components/features are named on Kedro-Viz, making it hard to tell what is and what is not being used once telemetry is active

Did we ever understand 1.?

@rashidakanchwala
Copy link
Contributor Author

rashidakanchwala commented Jul 24, 2024

  1. For one; i did live data tracking on both Production and Development Heap and tested all the click events on Kedro-viz that we were tracking. We were tracking everything but the naming wasn't correct/clear so we fixed that in Refactor: Replace data-heap-event with standardized data-test for Cypress and Telemetry #1995

@rashidakanchwala
Copy link
Contributor Author

rashidakanchwala commented Jul 24, 2024

I don't know if this issue is closed though; as we still need to create a proper heap dashboard. A part of this issue is closed: improving tracking to the code.

@yetudada
Copy link
Contributor

@rashidakanchwala Okay, that’s fair. Maybe what would be helpful is if you could complete the description for the GitHub issue and describe what needs to be done, because they can be sub-tickets of this one.

Also, this means we should assume that the ratio of Framework to Kedro-Viz users is actually correct, based on what you found?

@rashidakanchwala
Copy link
Contributor Author

Yes, I believe so. Besides, we check this ratio through CLI commands rather than UI interactions. Specifically, we track unique users who run kedro run and determine how many of them also run kedro viz or kedro viz run

Agree, improve telemetry is more of an epic which we need to break down into multiple tickets. I will do that now.

@rashidakanchwala rashidakanchwala changed the title Improve Kedro-viz telemetry Improve Kedro-viz telemetry tracking in the codebase Jul 24, 2024
@rashidakanchwala
Copy link
Contributor Author

closing this as 99 tickets later we have a follow up ticket :) #1999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants