Skip to content

Commit

Permalink
Lint fixes
Browse files Browse the repository at this point in the history
Signed-off-by: Jitendra Gundaniya <[email protected]>
  • Loading branch information
jitu5 committed Sep 30, 2024
1 parent 6e3f34d commit dc266af
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 10 deletions.
2 changes: 1 addition & 1 deletion package/kedro_viz/api/apps.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def _create_base_api_app() -> FastAPI:
@app.middleware("http")
async def set_secure_headers(request, call_next):
response = await call_next(request)
secure_headers.framework.fastapi(response)
secure_headers.framework.fastapi(response) # pylint: disable=no-member
return response

return app
Expand Down
4 changes: 3 additions & 1 deletion package/kedro_viz/data_access/managers.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,9 @@ def add_node_input(
task_node: TaskNode,
modular_pipelines_repo_obj: ModularPipelinesRepository,
is_free_input: bool = False,
) -> Union[DataNode, TranscodedDataNode, ParametersNode]:
) -> Union[
DataNode, TranscodedDataNode, ParametersNode
]: # pylint: too-many-arguments
"""Add a Kedro node's input as a DataNode, TranscodedDataNode or ParametersNode
to the NodesRepository for a given registered pipeline ID.
Expand Down
1 change: 0 additions & 1 deletion package/kedro_viz/data_access/repositories/catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ def get_dataset(self, dataset_name: str) -> Optional["AbstractDataset"]:
else: # pragma: no cover
dataset_obj = self._catalog._get_dataset(dataset_name)
except DatasetNotFoundError:
# pylint: disable=abstract-class-instantiated
dataset_obj = MemoryDataset() # type: ignore[abstract]

return dataset_obj
Expand Down
1 change: 1 addition & 0 deletions package/kedro_viz/integrations/kedro/data_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ def _load_data_helper(
return catalog, pipelines_dict, session_store, stats_dict


# pylint: too-many-arguments
def load_data(
project_path: Path,
env: Optional[str] = None,
Expand Down
2 changes: 1 addition & 1 deletion package/kedro_viz/integrations/kedro/telemetry.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ def get_heap_identity() -> Optional[str]: # pragma: no cover
return None
try:
return _get_or_create_uuid()
except Exception:
except Exception: # pragma: no cover
return None
2 changes: 1 addition & 1 deletion package/kedro_viz/launchers/cli/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def run(
include_hooks,
params,
lite,
):
): # pylint: too-many-arguments
"""Launch local Kedro Viz instance"""
# Deferring Imports
import multiprocessing
Expand Down
2 changes: 1 addition & 1 deletion package/kedro_viz/launchers/cli/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def _load_and_deploy_viz(
package_name,
process_completed,
exception_queue,
):
): # pylint: too-many-arguments
"""Loads Kedro Project data, creates a deployer and deploys to a platform"""
try:
from kedro_viz.integrations.deployment.deployer_factory import DeployerFactory
Expand Down
4 changes: 2 additions & 2 deletions package/kedro_viz/models/flowchart.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def create_data_node(
stats: Optional[Dict],
modular_pipelines: Optional[Set[str]],
is_free_input: bool = False,
) -> Union["DataNode", "TranscodedDataNode"]:
) -> Union["DataNode", "TranscodedDataNode"]: # pylint: too-many-arguments
"""Create a graph node of type data for a given Kedro Dataset instance.
Args:
dataset_id: A hashed id for the dataset node
Expand Down Expand Up @@ -224,7 +224,7 @@ def create_parameters_node(
tags: Set[str],
parameters: AbstractDataset,
modular_pipelines: Optional[Set[str]],
) -> "ParametersNode":
) -> "ParametersNode": # pylint: too-many-arguments
"""Create a graph node of type parameters for a given Kedro parameters dataset instance.
Args:
dataset_id: A hashed id for the parameters node
Expand Down
4 changes: 2 additions & 2 deletions package/kedro_viz/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def load_and_populate_data(
pipeline_name: Optional[str] = None,
extra_params: Optional[Dict[str, Any]] = None,
is_lite: bool = False,
):
): # pylint: too-many-arguments
"""Loads underlying Kedro project data and populates Kedro Viz Repositories"""

# Loads data from underlying Kedro Project
Expand Down Expand Up @@ -84,7 +84,7 @@ def run_server(
package_name: Optional[str] = None,
extra_params: Optional[Dict[str, Any]] = None,
is_lite: bool = False,
): # pylint: disable=redefined-outer-name
): # pylint: disable=redefined-outer-name, too-many-arguments
"""Run a uvicorn server with a FastAPI app that either launches API response data from a file
or from reading data from a real Kedro project.
Expand Down

0 comments on commit dc266af

Please sign in to comment.