Hot fix for backward compatiblity of kedro datasets (#1600)

* hot fix for backward compatiblity in kedro datasets and viz Signed-off-by: ravi-kumar-pilla <[email protected]> * upgrade plotly Signed-off-by: ravi-kumar-pilla <[email protected]> * upgrading plotly as per kedro datasets Signed-off-by: ravi-kumar-pilla <[email protected]> --------- Signed-off-by: ravi-kumar-pilla <[email protected]>
kedro-org · Oct 24, 2023 · 7922698 · 7922698
1 parent 8da0cf4
commit 7922698
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 7 deletions.
diff --git a/package/features/steps/lower_requirements.txt b/package/features/steps/lower_requirements.txt
@@ -4,7 +4,7 @@ fsspec==2021.4
 aiofiles==22.1.0
 uvicorn[standard]==0.22.0
 watchgod==0.8.2
-plotly==4.0
+plotly==4.8
 packaging==23.0
 pandas==1.3; python_version < '3.10'
 pandas==1.5; python_version >= '3.10'

diff --git a/package/kedro_viz/integrations/kedro/data_loader.py b/package/kedro_viz/integrations/kedro/data_loader.py
@@ -212,22 +212,27 @@ def matplotlib_writer_load(dataset: matplotlib.MatplotlibWriter) -> str:
     getattr(plotly, "JSONDataset")  # Trigger import
     plotly.JSONDataset._load = json_dataset.JSONDataset._load
 except (ImportError, AttributeError):
-    pass
+    getattr(plotly, "JSONDataSet")  # Trigger import
+    plotly.JSONDataSet._load = json_dataset.JSONDataSet._load
+
 
 try:
     getattr(plotly, "PlotlyDataset")  # Trigger import
     plotly.PlotlyDataset._load = json_dataset.JSONDataset._load
 except (ImportError, AttributeError):
-    pass
+    getattr(plotly, "PlotlyDataSet")  # Trigger import
+    plotly.PlotlyDataSet._load = json_dataset.JSONDataSet._load
 
 try:
     getattr(tracking, "JSONDataset")  # Trigger import
     tracking.JSONDataset._load = json_dataset.JSONDataset._load
 except (ImportError, AttributeError):
-    pass
+    getattr(tracking, "JSONDataSet")  # Trigger import
+    tracking.JSONDataSet._load = json_dataset.JSONDataSet._load
 
 try:
     getattr(tracking, "MetricsDataset")  # Trigger import
     tracking.MetricsDataset._load = json_dataset.JSONDataset._load
 except (ImportError, AttributeError):
-    pass
+    getattr(tracking, "MetricsDataSet")  # Trigger import
+    tracking.MetricsDataSet._load = json_dataset.JSONDataSet._load
diff --git a/package/kedro_viz/models/experiment_tracking.py b/package/kedro_viz/models/experiment_tracking.py
@@ -68,6 +68,10 @@ class TrackingDatasetGroup(str, Enum):
     "matplotlib.matplotlib_writer.MatplotlibWriter": TrackingDatasetGroup.PLOT,
     "tracking.metrics_dataset.MetricsDataset": TrackingDatasetGroup.METRIC,
     "tracking.json_dataset.JSONDataset": TrackingDatasetGroup.JSON,
+    "plotly.plotly_dataset.PlotlyDataSet": TrackingDatasetGroup.PLOT,
+    "plotly.json_dataset.JSONDataSet": TrackingDatasetGroup.PLOT,
+    "tracking.metrics_dataset.MetricsDataSet": TrackingDatasetGroup.METRIC,
+    "tracking.json_dataset.JSONDataSet": TrackingDatasetGroup.JSON,
 }
 
 

diff --git a/package/kedro_viz/models/flowchart.py b/package/kedro_viz/models/flowchart.py
@@ -468,6 +468,8 @@ def is_plot_node(self):
         return self.dataset_type in (
             "plotly.plotly_dataset.PlotlyDataset",
             "plotly.json_dataset.JSONDataset",
+            "plotly.plotly_dataset.PlotlyDataSet",
+            "plotly.json_dataset.JSONDataSet",
         )
 
     def is_image_node(self):
@@ -476,11 +478,17 @@ def is_image_node(self):
 
     def is_metric_node(self):
         """Check if the current node is a metrics node."""
-        return self.dataset_type in ("tracking.metrics_dataset.MetricsDataset",)
+        return self.dataset_type in (
+            "tracking.metrics_dataset.MetricsDataset",
+            "tracking.metrics_dataset.MetricsDataSet",
+        )
 
     def is_json_node(self):
         """Check if the current node is a JSONDataset node."""
-        return self.dataset_type in ("tracking.json_dataset.JSONDataset",)
+        return self.dataset_type in (
+            "tracking.json_dataset.JSONDataset",
+            "tracking.json_dataset.JSONDataSet",
+        )
 
     def is_tracking_node(self):
         """Checks if the current node is a tracking data node"""

diff --git a/src/config.js b/src/config.js
@@ -103,6 +103,10 @@ export const shortTypeMapping = {
   'matplotlib.matplotlib_writer.MatplotlibWriter': 'image',
   'tracking.json_dataset.JSONDataset': 'JSONTracking',
   'tracking.metrics_dataset.MetricsDataset': 'metricsTracking',
+  'plotly.plotly_dataset.PlotlyDataSet': 'plotly',
+  'plotly.json_dataset.JSONDataSet': 'plotly',
+  'tracking.json_dataset.JSONDataSet': 'JSONTracking',
+  'tracking.metrics_dataset.MetricsDataSet': 'metricsTracking',
 };
 
 export const tabLabels = ['Overview', 'Metrics', 'Plots'];