update component name and fix compatible issue

Signed-off-by: huongg <[email protected]>
kedro-org · Jun 5, 2024 · 4431ff0 · 4431ff0
1 parent 8c06a8d
commit 4431ff0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/.../compatibility-view/compatibility-view.js → ...ty-error-view/compatibility-error-view.js b/.../compatibility-view/compatibility-view.js → ...ty-error-view/compatibility-error-view.js
@@ -1,7 +1,7 @@
 import React from 'react';
 import Button from '../../ui/button';
 
-const CompatibilityView = ({ onClick }) => (
+const CompatibilityErrorView = ({ onClick }) => (
   <div className="shareable-url-modal__button-wrapper shareable-url-modal__button-wrapper--right">
     <Button mode="secondary" onClick={onClick} size="small">
       Cancel
@@ -16,4 +16,4 @@ const CompatibilityView = ({ onClick }) => (
   </div>
 );
 
-export default CompatibilityView;
+export default CompatibilityErrorView;
diff --git a/src/components/shareable-url-modal/shareable-url-modal.js b/src/components/shareable-url-modal/shareable-url-modal.js
@@ -15,7 +15,7 @@ import {
 import Modal from '../ui/modal';
 
 import PublishedView from './published-view/published-view';
-import CompatibilityView from './compatibility-view/compatibility-view';
+import CompatibilityErrorView from './compatibility-error-view/compatibility-error-view';
 import MainView from './main-view/main-view';
 import LoadingView from './loading-view/loading-view';
 import ErrorView from './error-view/error-view';
@@ -170,8 +170,16 @@ const ShareableUrlModal = ({ onToggleModal, visible }) => {
   const handleModalClose = () => {
     onToggleModal(false);
     if (deploymentState !== 'incompatible') {
-      setDeploymentState('default');
+      // reset the state to default as long as the user's fsspec package version is compatible
+      //  and there are nothing stored in localStorage
+      if (Object.keys(hostingPlatformLocalStorageVal).length === 0) {
+        setDeploymentState('default');
+      }
+
+      // if there are items stored in localStorage, display the published view
+      displayPublishedView();
     }
+
     setResponseError(null);
     setIsLoading(false);
     setResponseUrl(null);
@@ -181,7 +189,6 @@ const ShareableUrlModal = ({ onToggleModal, visible }) => {
       hasPlatform: false,
       hasEndpoint: false,
     });
-    displayPublishedView();
   };
 
   const { platform } = inputValues || {};
@@ -211,7 +218,7 @@ const ShareableUrlModal = ({ onToggleModal, visible }) => {
       visible={visible.shareableUrlModal}
     >
       {!isCompatible ? (
-        <CompatibilityView onClick={handleModalClose} />
+        <CompatibilityErrorView onClick={handleModalClose} />
       ) : showPublishedView ? (
         <PublishedView
           hostingPlatformLocalStorageVal={hostingPlatformLocalStorageVal}