Skip to content

Commit

Permalink
Lint fixes
Browse files Browse the repository at this point in the history
Signed-off-by: Jitendra Gundaniya <[email protected]>
  • Loading branch information
jitu5 committed Sep 30, 2024
1 parent 9a72b2a commit 193aa59
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 11 deletions.
2 changes: 1 addition & 1 deletion package/.pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ valid-metaclass-classmethod-first-arg=mcs
[DESIGN]

# Maximum number of arguments for function / method
max-args=5
max-args=12

# Maximum number of attributes for a class (see R0902).
max-attributes=7
Expand Down
4 changes: 1 addition & 3 deletions package/kedro_viz/data_access/managers.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,7 @@ def add_node_input(
task_node: TaskNode,
modular_pipelines_repo_obj: ModularPipelinesRepository,
is_free_input: bool = False,
) -> Union[
DataNode, TranscodedDataNode, ParametersNode
]: # pylint: disable=too-many-arguments
) -> Union[DataNode, TranscodedDataNode, ParametersNode]:
"""Add a Kedro node's input as a DataNode, TranscodedDataNode or ParametersNode
to the NodesRepository for a given registered pipeline ID.
Expand Down
1 change: 0 additions & 1 deletion package/kedro_viz/integrations/kedro/data_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ def _load_data_helper(
return catalog, pipelines_dict, session_store, stats_dict


# pylint: disable=too-many-arguments
def load_data(
project_path: Path,
env: Optional[str] = None,
Expand Down
2 changes: 1 addition & 1 deletion package/kedro_viz/launchers/cli/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def run(
include_hooks,
params,
lite,
): # pylint: disable=too-many-arguments
):
"""Launch local Kedro Viz instance"""
# Deferring Imports
import multiprocessing
Expand Down
2 changes: 1 addition & 1 deletion package/kedro_viz/launchers/cli/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def _load_and_deploy_viz(
package_name,
process_completed,
exception_queue,
): # pylint: disable=too-many-arguments
):
"""Loads Kedro Project data, creates a deployer and deploys to a platform"""
try:
from kedro_viz.integrations.deployment.deployer_factory import DeployerFactory
Expand Down
4 changes: 2 additions & 2 deletions package/kedro_viz/models/flowchart.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def create_data_node(
stats: Optional[Dict],
modular_pipelines: Optional[Set[str]],
is_free_input: bool = False,
) -> Union["DataNode", "TranscodedDataNode"]: # pylint: disable=too-many-arguments
) -> Union["DataNode", "TranscodedDataNode"]:
"""Create a graph node of type data for a given Kedro Dataset instance.
Args:
dataset_id: A hashed id for the dataset node
Expand Down Expand Up @@ -224,7 +224,7 @@ def create_parameters_node(
tags: Set[str],
parameters: AbstractDataset,
modular_pipelines: Optional[Set[str]],
) -> "ParametersNode": # pylint: disable=too-many-arguments
) -> "ParametersNode":
"""Create a graph node of type parameters for a given Kedro parameters dataset instance.
Args:
dataset_id: A hashed id for the parameters node
Expand Down
4 changes: 2 additions & 2 deletions package/kedro_viz/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def load_and_populate_data(
pipeline_name: Optional[str] = None,
extra_params: Optional[Dict[str, Any]] = None,
is_lite: bool = False,
): # pylint: disable=too-many-arguments
):
"""Loads underlying Kedro project data and populates Kedro Viz Repositories"""

# Loads data from underlying Kedro Project
Expand Down Expand Up @@ -84,7 +84,7 @@ def run_server(
package_name: Optional[str] = None,
extra_params: Optional[Dict[str, Any]] = None,
is_lite: bool = False,
): # pylint: disable=redefined-outer-name, too-many-arguments
): # pylint: disable=redefined-outer-name
"""Run a uvicorn server with a FastAPI app that either launches API response data from a file
or from reading data from a real Kedro project.
Expand Down

0 comments on commit 193aa59

Please sign in to comment.