Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Fix Kedro lint and test errors 🛠️ #8

Merged
merged 5 commits into from
Jan 28, 2021
Merged

Conversation

deepyaman
Copy link
Member

No description provided.

@deepyaman deepyaman changed the title Fix expected project name in test_project_name Fix Kedro lint and test errors 🛠️ Nov 20, 2020
@@ -49,7 +49,7 @@ def project_context():

class TestProjectContext:
def test_project_name(self, project_context):
assert project_context.project_name == "kedro-tutorial"
assert project_context.project_name == "kedro_tutorial"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're were, does line 55 still pass?

Copy link
Contributor

@lorenabalan lorenabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thaaaank you! ✨

@lorenabalan lorenabalan requested a review from yetudada November 20, 2020 14:50
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Let's get these in...

@stichbury stichbury merged commit 7b1990b into master Jan 28, 2021
antonymilne pushed a commit to antonymilne/kedro-training that referenced this pull request Mar 18, 2021
@merelcht merelcht deleted the deepyaman-patch-1 branch November 17, 2021 11:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants