Merge pull request #764 from mlight3/mlight3/placeholder

Add usePlaceholderAsFailure to show placeholder in case of image loading failure
kean · Mar 23, 2024 · eb7c5b8 · eb7c5b8
2 parents d205efe + 4887e94
commit eb7c5b8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/Sources/NukeUI/Internal.swift b/Sources/NukeUI/Internal.swift
@@ -29,23 +29,27 @@ typealias _PlatformColor = UIColor
 extension _PlatformBaseView {
     @discardableResult
     func pinToSuperview() -> [NSLayoutConstraint] {
+        guard let superview else { return [] }
+
         translatesAutoresizingMaskIntoConstraints = false
         let constraints = [
-            topAnchor.constraint(equalTo: superview!.topAnchor),
-            bottomAnchor.constraint(equalTo: superview!.bottomAnchor),
-            leftAnchor.constraint(equalTo: superview!.leftAnchor),
-            rightAnchor.constraint(equalTo: superview!.rightAnchor)
+            topAnchor.constraint(equalTo: superview.topAnchor),
+            bottomAnchor.constraint(equalTo: superview.bottomAnchor),
+            leftAnchor.constraint(equalTo: superview.leftAnchor),
+            rightAnchor.constraint(equalTo: superview.rightAnchor)
         ]
         NSLayoutConstraint.activate(constraints)
         return constraints
     }
 
     @discardableResult
     func centerInSuperview() -> [NSLayoutConstraint] {
+        guard let superview else { return [] }
+
         translatesAutoresizingMaskIntoConstraints = false
         let constraints = [
-            centerXAnchor.constraint(equalTo: superview!.centerXAnchor),
-            centerYAnchor.constraint(equalTo: superview!.centerYAnchor)
+            centerXAnchor.constraint(equalTo: superview.centerXAnchor),
+            centerYAnchor.constraint(equalTo: superview.centerYAnchor)
         ]
         NSLayoutConstraint.activate(constraints)
         return constraints

diff --git a/Sources/NukeUI/LazyImageView.swift b/Sources/NukeUI/LazyImageView.swift
@@ -53,6 +53,8 @@ public final class LazyImageView: _PlatformBaseView {
         }
     }
 
+    public var usePlaceholderAsFailure = true
+
     private var placeholderViewConstraints: [NSLayoutConstraint] = []
 
     // MARK: Failure View
@@ -323,7 +325,11 @@ public final class LazyImageView: _PlatformBaseView {
         case let .success(response):
             display(response.container, isFromMemory: isSync)
         case .failure:
-            setFailureViewHidden(false)
+            if usePlaceholderAsFailure {
+                setPlaceholderViewHidden(false)
+            } else {
+                setFailureViewHidden(false)
+            }
         }
 
         imageTask = nil