DataLoader: don't wrap an already Encodable value in AnyEncodable #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i don't understand what this extra wrap does. the value is already `Encodable` so it should be possible to directly encode it
kean
reviewed
Apr 25, 2024
| @@ -357,7 +357,7 @@ func encode(_ value: Encodable, using encoder: JSONEncoder) async throws -> Data | |||
| return string.data(using: .utf8) | |||
| } else { | |||
| return try await Task.detached { | |||
| try encoder.encode(AnyEncodable(value: value)) | |||
| try encoder.encode(value) | |||
There was a problem hiding this comment.
I think AnyEncodable can now also be removed. It was probably a rudiment from one of the earlier implementations or was required by one of the earlier Swift versions – I can't remember now.
There was a problem hiding this comment.
there might have been a time when AnyEncodable didn't support Optionals or something
There was a problem hiding this comment.
want me to remove and update this PR? or you want to do it?
There was a problem hiding this comment.
I would appreciate if you could remove it, but I can do it myself later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i don't understand what this extra wrap does. the value is already
Encodableso it should be possible to directly encode it