Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation and refactor AbstractModuleTestHelper #297

Merged
merged 8 commits into from
Jan 27, 2025
Merged

Improve documentation and refactor AbstractModuleTestHelper #297

merged 8 commits into from
Jan 27, 2025

Conversation

MSattrtand
Copy link
Collaborator

No description provided.

@blcham blcham force-pushed the improved-documentation branch from ff00c04 to 2f4530d Compare January 23, 2025 09:39
@blcham
Copy link
Contributor

blcham commented Jan 23, 2025

@blcham need to refactor this code so it is not duplicated across projects:

  • most of the functionality should be moved to s-pipes-test, but first dependency on s-pipes-core must be removed (otherwise cyclic dependency)

@blcham blcham mentioned this pull request Jan 23, 2025
Merged
@blcham
Copy link
Contributor

blcham commented Jan 23, 2025

@MSattrtand
image

@blcham blcham changed the title Improved documentation for AbstractModuleTestHelper Improved documentation and refactoring of AbstractModuleTestHelper Jan 23, 2025
@blcham blcham changed the title Improved documentation and refactoring of AbstractModuleTestHelper Improve documentation and refactor AbstractModuleTestHelper Jan 23, 2025
@MSattrtand MSattrtand requested a review from blcham January 24, 2025 12:06
blcham
blcham requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

s-pipes-test/src/main/java/cz/cvut/spipes/modules/AbstractModuleTestHelper.java Outdated Show resolved Hide resolved
s-pipes-test/src/main/java/cz/cvut/spipes/modules/AbstractModuleTestHelper.java Outdated Show resolved Hide resolved
@MSattrtand MSattrtand requested a review from blcham January 24, 2025 14:10
blcham
blcham approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

blcham
blcham approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

s-pipes-test/src/main/java/cz/cvut/spipes/modules/AbstractModuleTestHelper.java Outdated Show resolved Hide resolved
@blcham blcham merged commit a0d4dba into main Jan 27, 2025
2 checks passed
@blcham blcham deleted the improved-documentation branch January 27, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
SPipes related projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSattrtand @blcham