refactor: rename

kawamataryo · Jan 3, 2025 · a758b3a · a758b3a
1 parent 16ae674
commit a758b3a
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 27 deletions.
diff --git a/src/lib/bskyHelpers.ts b/src/lib/bskyHelpers.ts
@@ -1,16 +1,12 @@
 import type { ProfileView } from "@atproto/api/dist/client/types/app/bsky/actor/defs";
+import type { CrawledUserInfo } from "~types";
 import { BSKY_PROFILE_LABEL, BSKY_USER_MATCH_TYPE } from "./constants";
 
-type xUserInfo = {
-  bskyHandleInDescription: string;
-  accountName: string;
-  accountNameRemoveUnderscore: string;
-  accountNameReplaceUnderscore: string;
-  displayName: string;
-};
-
 export const isSimilarUser = (
-  xUserInfo: xUserInfo,
+  crawledUserInfo: Omit<
+    CrawledUserInfo,
+    "originalAvatar" | "originalProfileLink"
+  >,
   bskyProfile: ProfileView | undefined,
 ): {
   isSimilar: boolean;
@@ -24,10 +20,10 @@ export const isSimilarUser = (
   }
 
   // this is to handle the case where the user has a bsky handle in their description
-  if (xUserInfo.bskyHandleInDescription) {
+  if (crawledUserInfo.bskyHandleInDescription) {
     const formattedBskyHandle = bskyProfile.handle.replace("@", "");
     const formattedBskyHandleInDescription =
-      xUserInfo.bskyHandleInDescription.replace("@", "");
+      crawledUserInfo.bskyHandleInDescription.replace("@", "");
     if (
       formattedBskyHandle === formattedBskyHandleInDescription ||
       formattedBskyHandle.includes(formattedBskyHandleInDescription)
@@ -39,16 +35,15 @@ export const isSimilarUser = (
     }
   }
 
-  const lowerCaseNames = Object.entries(xUserInfo).reduce<xUserInfo>(
-    (acc, [key, value]) => {
-      if (!value) {
-        return acc;
-      }
-      acc[key] = value.toLowerCase();
+  const lowerCaseNames = Object.entries(
+    crawledUserInfo,
+  ).reduce<CrawledUserInfo>((acc, [key, value]) => {
+    if (!value) {
       return acc;
-    },
-    {} as xUserInfo,
-  );
+    }
+    acc[key] = value.toLowerCase();
+    return acc;
+  }, {} as CrawledUserInfo);
 
   const bskyHandle = bskyProfile.handle
     .toLocaleLowerCase()

diff --git a/src/lib/searchBskyUsers.ts b/src/lib/searchBskyUsers.ts
@@ -12,7 +12,9 @@ export const searchBskyUser = async ({
   userData: CrawledUserInfo;
 }) => {
   const searchTerms = [
-    ...(userData.bskyHandle ? [userData.bskyHandle] : []),
+    ...(userData.bskyHandleInDescription
+      ? [userData.bskyHandleInDescription]
+      : []),
     userData.accountNameRemoveUnderscore,
     userData.accountNameReplaceUnderscore,
     userData.displayName,
@@ -39,7 +41,7 @@ export const searchBskyUser = async ({
         const { isSimilar: isUserFound, type } = isSimilarUser(
           // TODO: simplify
           {
-            bskyHandleInDescription: userData.bskyHandle,
+            bskyHandleInDescription: userData.bskyHandleInDescription,
             accountName: userData.accountName,
             accountNameRemoveUnderscore: userData.accountNameRemoveUnderscore,
             accountNameReplaceUnderscore: userData.accountNameReplaceUnderscore,

diff --git a/src/lib/services/instagramService.ts b/src/lib/services/instagramService.ts
@@ -66,7 +66,7 @@ export class InstagramService implements IService {
       displayName,
       accountNameRemoveUnderscore,
       accountNameReplaceUnderscore,
-      bskyHandle: "",
+      bskyHandleInDescription: "",
       originalAvatar: avatarSrc,
       originalProfileLink: `https://www.instagram.com/${_accountName}`,
     };

diff --git a/src/lib/services/threadsService.ts b/src/lib/services/threadsService.ts
@@ -71,7 +71,7 @@ export class ThreadsService implements IService {
       displayName,
       accountNameRemoveUnderscore,
       accountNameReplaceUnderscore,
-      bskyHandle: "",
+      bskyHandleInDescription: "",
       originalAvatar: avatarSrc,
       originalProfileLink: `https://www.threads.net/@${_accountName}`,
     };

diff --git a/src/lib/services/xService.ts b/src/lib/services/xService.ts
@@ -46,7 +46,7 @@ export class XService implements IService {
     const accountNameRemoveUnderscore = accountName.replaceAll("_", ""); // bsky does not allow underscores in handle, so remove them.
     const accountNameReplaceUnderscore = accountName.replaceAll("_", "-");
     const displayName = displayNameEl?.textContent;
-    const bskyHandle =
+    const bskyHandleInDescription =
       userCell.textContent?.match(
         new RegExp(`([^/\\s]+\\.${BSKY_DOMAIN})`),
       )?.[1] ??
@@ -64,7 +64,7 @@ export class XService implements IService {
       displayName,
       accountNameRemoveUnderscore,
       accountNameReplaceUnderscore,
-      bskyHandle,
+      bskyHandleInDescription,
       originalAvatar,
       originalProfileLink: `https://x.com/${accountName}`,
     };

diff --git a/src/types.ts b/src/types.ts
@@ -38,7 +38,7 @@ export type CrawledUserInfo = {
   displayName: string;
   accountNameRemoveUnderscore: string;
   accountNameReplaceUnderscore: string;
-  bskyHandle: string;
+  bskyHandleInDescription: string;
   originalAvatar: string;
   originalProfileLink: string;
 };