New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [Spectrogram] Resample spectrogram at Mel frequencies without ch… #3861

Merged

katspaugh merged 1 commit into katspaugh:main from lucastheis:main

Sep 9, 2024

Contributor

lucastheis commented Sep 9, 2024 •

edited

Loading

This changes melFilterBank such that power spectra are correctly resampled.

Short description

The way that melFilterBank is computed now, the Mel spectrogram is not calculated by linearly interpolating the linear spectrogram at nearby frequencies. Instead, it computes a weighted average where the sum of weights depends on the frequency. One consequence of this is that the Mel spectrogram of white noise does not appear to be white.

Implementation details

The Mel spectrogram is now calculated by resampling and linearly interpolating the linear spectrogram.

Screenshots

Spectrogram of Gaussian white noise before:

Spectrogram of Gaussian white noise after:

melFilterBank before:

melFilterBank after:

Checklist

This PR is covered by e2e tests
It introduces no breaking API changes


          Fix: [Spectrogram] Resample spectrogram at Mel frequencies without ch…

8d2e830

…anging magnitudes

katspaugh approved these changes

View reviewed changes

Owner

katspaugh left a comment

Thank you!

katspaugh merged commit 4647779 into katspaugh:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet