Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support seeking with no audio loaded #3512

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Feat: support seeking with no audio loaded #3512

merged 1 commit into from
Jan 24, 2024

Conversation

katspaugh
Copy link
Owner

Short description

Resolves #3298

Implementation details

If no audio is loaded but a waveform is rendered using pre-decoded peaks and duration, clicking on the waveform will now set the cursor to that position.

Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh merged commit c901fc2 into main Jan 24, 2024
4 checks passed
@katspaugh katspaugh deleted the seek-no-audio branch January 24, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeking doesn't work if no audio is provided
1 participant