Refactor: promise-based chunked rendering #3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Deploying with
|
| Latest commit: |
13b0b15
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://159db3a5.wavesurfer-js.pages.dev |
| Branch Preview URL: | https://promises.wavesurfer-js.pages.dev |
src/renderer.ts
Outdated
Comment on lines
602
to
607
| await Promise.allSettled( | ||
| Array.from({ length: audioData.numberOfChannels }).map((_, i) => { | ||
| const options = { ...this.options, ...this.options.splitChannels?.[i] } | ||
| return this.renderChannel([audioData.getChannelData(i)], options, width) | ||
| }), | ||
| ) |
There was a problem hiding this comment.
allSettled will prevent the catch from being invoked in subsequent renders.
This seems like more render calls would be happing than one might expect.
I think Promise.all might be the better option here. But I may be miss understanding something here.
There was a problem hiding this comment.
True, thank you, we want to reject the entire promise when one of them fail.
brian-byassee
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
As outlined in a comment in #3480, I've refactored the code that was awaiting all waveform chunks to be rendered into sequenced promises.
Implementation details
The rendering timeouts are now also promise-based, and it a render timeout is cancelled due to another rendering (e.g. when zooming using a slider), it will also reject the correspondng promise. So it's possible to track the entire chain of promises to determine where
rendercompleteshould be called.@brian-byassee @jason-whitted please review