Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: rollup all types into a separate types.d.ts file #3451

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

katspaugh
Copy link
Owner

Short description

I've cleaned up the public API a bit, and restored the combined types in types.d.ts which were reverted in #3450.

Breaking changes

  • Removed addEventListener and removeEventListener. Only on and un should be used in the public API.
  • Renamed BasePlugin.init to BasePlugin._init to discourage calling it directly, as it's an internal method that has to remain public.

Additions

  • WebAudioPlayer.getChannelData – needed by the Multitrack plugin.
  • dist/types.d.ts – all core wavesurfer types in one module

Copy link
Contributor

github-actions bot commented Dec 28, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

cloudflare-workers-and-pages bot commented Dec 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4942324
Status: ✅  Deploy successful!
Preview URL: https://82ba3522.wavesurfer-js.pages.dev
Branch Preview URL: https://rollup-types.wavesurfer-js.pages.dev

View logs

@katspaugh katspaugh merged commit 8b3b00e into main Dec 28, 2023
4 checks passed
@katspaugh katspaugh deleted the rollup-types branch December 28, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant