Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rm force-loading of audio #3436

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Fix: rm force-loading of audio #3436

merged 1 commit into from
Dec 23, 2023

Conversation

katspaugh
Copy link
Owner

Short description

Resolves #3435

Implementation details

Calling load isn't necessary. The browser will now decide whether to load audio or not based on the preload property of the audio element which wavesurfer doesn't explicitly set. So it should likely default to metadata as per the docs.

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b168ab5
Status: ✅  Deploy successful!
Preview URL: https://a54a05b5.wavesurfer-js.pages.dev
Branch Preview URL: https://fix-load.wavesurfer-js.pages.dev

View logs

Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh merged commit a00e6db into main Dec 23, 2023
4 checks passed
@katspaugh katspaugh deleted the fix-load branch December 23, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing peaks and duration (predecoded) still downloads content in chrome
1 participant