Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [Regions] grabbing cursor on mousedown #3423

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fix: [Regions] grabbing cursor on mousedown #3423

merged 1 commit into from
Dec 18, 2023

Conversation

katspaugh
Copy link
Owner

Short description

Resolves #3381

Implementation details

When dragging a region, the cursor should change to grabbing immediately on click.

@github-actions GitHub Actions
Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff3b6f3
Status: ✅  Deploy successful!
Preview URL: https://29053813.wavesurfer-js.pages.dev
Branch Preview URL: https://fix-grabbing.wavesurfer-js.pages.dev

View logs

@katspaugh katspaugh merged commit 7fe005a into main Dec 18, 2023
4 checks passed
@katspaugh katspaugh deleted the fix-grabbing branch December 18, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird behavior when clicking and dragging a region
1 participant
@katspaugh