Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: scroll when dragging #3417

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Fix: scroll when dragging #3417

merged 1 commit into from
Dec 17, 2023

Conversation

katspaugh
Copy link
Owner

Short description

Resolves #3384

Implementation details

Drag-to-seek will now scroll the waveform when dragging close to the edge.

Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6de9c1d
Status: ✅  Deploy successful!
Preview URL: https://e015f71c.wavesurfer-js.pages.dev
Branch Preview URL: https://scroll-drag.wavesurfer-js.pages.dev

View logs

@katspaugh katspaugh merged commit 7e30d9a into main Dec 17, 2023
4 checks passed
@katspaugh katspaugh deleted the scroll-drag branch December 17, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag-to-seek: dragging past the edge is broken in 7.4 and 7.5
1 participant