Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Regions] improve overlapping content #3373

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Fix: [Regions] improve overlapping content #3373

merged 2 commits into from
Dec 3, 2023

Conversation

katspaugh
Copy link
Owner

Short description

Resolves #3300

Implementation details

The content size is now calculated for the text bounding box, not the entire region.

Copy link
Contributor

github-actions bot commented Dec 3, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

cloudflare-workers-and-pages bot commented Dec 3, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fc7fa44
Status: ✅  Deploy successful!
Preview URL: https://9fad4eb5.wavesurfer-js.pages.dev
Branch Preview URL: https://region-overlap.wavesurfer-js.pages.dev

View logs

@katspaugh katspaugh merged commit a6086db into main Dec 3, 2023
4 checks passed
@katspaugh katspaugh deleted the region-overlap branch December 3, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Region plugin content going out of bounds
1 participant