Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: avoid color bleed behind progress canvas #3285

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Fix: avoid color bleed behind progress canvas #3285

merged 1 commit into from
Oct 21, 2023

Conversation

katspaugh
Copy link
Owner

@katspaugh katspaugh commented Oct 21, 2023

Short description

Resolves #3270

Implementation details

The main waveform is now clipped so that it doesn't bleed through behind the progress waveform.

Screenshot 2023-10-21 at 14 15 47

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8bc0aa6
Status: ✅  Deploy successful!
Preview URL: https://6b4b2e2a.wavesurfer-js.pages.dev
Branch Preview URL: https://progress.wavesurfer-js.pages.dev

View logs

@github-actions
Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh merged commit ae13902 into main Oct 21, 2023
4 checks passed
@katspaugh katspaugh deleted the progress branch October 21, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress color does not completely fill the wave area
1 participant