Fix: setMediaElement to properly subscribe/unsubscribe media events #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- First we unsubscribe from all existing media event listeners - Then after setting new media element we subscribe to media events
jahangiranwari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
When we change the underlying
mediaelement usingsetMediaElementthe progress bar would not update as the track was playing. This was because of various media events subscriptions was missing.Resolves #3266
Implementation details
To ensure that we are properly handling setting of a new media element
setMediaElementhas been tweaked as follows:mediaelementmediaelementmediaHow to test it
mediaelement usingsetMediaElementThe progress bar should be updated as the track play progresses.
Screenshots
Checklist