Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Record] Access getAvailableAudioDevices with RecordPlugin #3269

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

hannahblair
Copy link
Contributor

@hannahblair hannahblair commented Oct 16, 2023

Short description

Updates the Record example to use RecordPlugin instead of record to access the getAvailableAudioDevices function.

Implementation details

How to test it

Screenshots

Checklist

  • This PR is covered by e2e tests
  • It introduces no breaking API changes

@hannahblair hannahblair changed the title Fix [Record]: Access getAvailableAudioDevices via RecordPlugin Fix [Record]: Access getAvailableAudioDevices with RecordPlugin Oct 16, 2023
@hannahblair hannahblair changed the title Fix [Record]: Access getAvailableAudioDevices with RecordPlugin Fix: [Record] Access getAvailableAudioDevices with RecordPlugin Oct 16, 2023
Copy link
Owner

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@katspaugh katspaugh merged commit 582c0ee into katspaugh:main Oct 16, 2023
@tscritch
Copy link
Contributor

@hannahblair great catch! Thank you!

@hannahblair hannahblair deleted the fix-record-example branch October 19, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants