Feat: [Regions] pass sensitivity threshold to enableDragSelection (#3437

)
katspaugh · Dec 23, 2023 · a1f9302 · a1f9302
1 parent a00e6db
commit a1f9302
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/draggable.ts b/src/draggable.ts
@@ -28,8 +28,6 @@ export function makeDraggable(
       const y = event.clientY
       const dx = x - startX
       const dy = y - startY
-      startX = x
-      startY = y
 
       if (isDragging || Math.abs(dx) > threshold || Math.abs(dy) > threshold) {
         const rect = element.getBoundingClientRect()
@@ -41,6 +39,9 @@ export function makeDraggable(
         }
 
         onDrag(dx, dy, x - left, y - top)
+
+        startX = x
+        startY = y
       }
     }
 

diff --git a/src/plugins/regions.ts b/src/plugins/regions.ts
@@ -535,7 +535,7 @@ class RegionsPlugin extends BasePlugin<RegionsPluginEvents, RegionsPluginOptions
    * Enable creation of regions by dragging on an empty space on the waveform.
    * Returns a function to disable the drag selection.
    */
-  public enableDragSelection(options: Omit<RegionParams, 'start' | 'end'>): () => void {
+  public enableDragSelection(options: Omit<RegionParams, 'start' | 'end'>, threshold = 3): () => void {
     const wrapper = this.wavesurfer?.getWrapper()
     if (!wrapper || !(wrapper instanceof HTMLElement)) return () => undefined
 
@@ -588,6 +588,8 @@ class RegionsPlugin extends BasePlugin<RegionsPluginEvents, RegionsPluginOptions
           region = null
         }
       },
+
+      threshold,
     )
   }