Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

add resp3 protocol part 2(double and big number) #79

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

chyroc
Copy link
Collaborator

@chyroc chyroc commented Aug 27, 2018

Pull Request for issue

#76

Description

  • double
  • big number

Testing Instructions

Excepted Behavior

Actual Behavior

Additional Comments

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #79 into master will increase coverage by 0.16%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage      72%   72.16%   +0.16%     
==========================================
  Files          11       11              
  Lines         750      776      +26     
==========================================
+ Hits          540      560      +20     
- Misses        191      195       +4     
- Partials       19       21       +2
Impacted Files Coverage Δ
internal/protcl/errors.go 17.64% <66.66%> (+10.5%) ⬆️
internal/protcl/resp3.go 74.56% <80%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea0f811...8d00139. Read the comment docs.

@kasvith kasvith merged commit bd4a4a5 into kasvith:master Aug 27, 2018
@kasvith
Copy link
Owner

kasvith commented Aug 27, 2018

tnx @chyroc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants