Adds missing logs and other minor convenient additions #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someone235
previously approved these changes
Dec 24, 2023
* Split logging of performance metrics Affects: - daemon.rs - simpa * Make daemon.rs log perf metrics if enabled * Log perf metrics via impl Display * Remove loglevel default changes With impl Display, we don't need to change loglevels to display perf metrics
michaelsutton
force-pushed
the
logs-etc
branch
from
c50ae76 to
5ecbbf6
Compare
someone235
approved these changes
Dec 28, 2023
KashProtocol
pushed a commit
to Kash-Protocol/rusty-kash
that referenced
this pull request
Jan 5, 2024
KashProtocol
pushed a commit
to Kash-Protocol/rusty-kash
that referenced
this pull request
Jan 8, 2024
KashProtocol
pushed a commit
to Kash-Protocol/rusty-kash
that referenced
this pull request
Jan 9, 2024
D-Stacks
pushed a commit
to D-Stacks/rusty-kaspa
that referenced
this pull request
Jan 23, 2024
* p2p connmanager - log the connect err * IBD with headers proof logs * log if search for missing bodies is taking too long * Exit early on pruning processor when exit signal is received * Exit early on pruning point validation when process exit is initiated * Rename is_process_exiting to is_consensus_exiting * Change atomic ordering for exit signal to relaxed * Split logging of performance metrics into better readable lines (#4) * Split logging of performance metrics Affects: - daemon.rs - simpa * Make daemon.rs log perf metrics if enabled * Log perf metrics via impl Display * Remove loglevel default changes With impl Display, we don't need to change loglevels to display perf metrics * use 2 sub-structs for metrics display * print precision + relocate fd * use RAM (over RES/RSS) + optimize and fix edge case in `to_human_readable` --------- Co-authored-by: coderofstuff <[email protected]>
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
* p2p connmanager - log the connect err * IBD with headers proof logs * log if search for missing bodies is taking too long * Exit early on pruning processor when exit signal is received * Exit early on pruning point validation when process exit is initiated * Rename is_process_exiting to is_consensus_exiting * Change atomic ordering for exit signal to relaxed * Split logging of performance metrics into better readable lines (#4) * Split logging of performance metrics Affects: - daemon.rs - simpa * Make daemon.rs log perf metrics if enabled * Log perf metrics via impl Display * Remove loglevel default changes With impl Display, we don't need to change loglevels to display perf metrics * use 2 sub-structs for metrics display * print precision + relocate fd * use RAM (over RES/RSS) + optimize and fix edge case in `to_human_readable` --------- Co-authored-by: coderofstuff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some missing logs and is meant to be an aggregated PR for other minor convenient additions. Please open a PR over this branch if you wish to add anything. All changes should be small in scope.
Some suggestions to add here:
Consensusan atomic boolean set atConsensus::signal_exitwhich can be used by processors such as the pruning processor to exit long operations early if the app is shutting down. Another place to use this flag isPruningProofManager::validate_pruning_point_proof.--norpcflag support tokaspadcmd optionsperf-monitormetrics log to two more readable and short lines. Consider printing numbers also in readable format with units such as KB,MB,GB. Change cmd optionperf_metrics_interval_secdefault value to 10. **** Current state:
Desired state:
(the only reason to keep the long numbers as well is for log parsing)