Store each relation child in its own key #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someone235
changed the title
someone235
force-pushed
the
relations-children-prefix
branch
2 times, most recently
from
51730e3 to
19a8b5e
Compare
Closed
someone235
force-pushed
the
relations-children-prefix
branch
2 times, most recently
from
f17fd2d to
94ffe39
Compare
someone235
force-pushed
the
relations-children-prefix
branch
from
94ffe39 to
3432558
Compare
someone235
force-pushed
the
relations-children-prefix
branch
from
b244f58 to
b0c8f0f
Compare
michaelsutton
previously approved these changes
Dec 1, 2023
someone235
force-pushed
the
relations-children-prefix
branch
from
fdc0134 to
0fad12f
Compare
- cache the new item only if the set entry already exists in the cache - fix bug in delete_bucket where set was emptied in cache but the entry was not removed
…ata for this hash
michaelsutton
approved these changes
Dec 5, 2023
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
* Store each relation child in its own key * Database version upgrade logic * Improve staging relations perf * Implement CachedDbSetAccess * Use BlockHasher for children store * Pass children readlock * clippy fix * Use default Debug impl for ReadLock * Address review comments * Remove relations rwlock * Get rid of relations service * Use RefCell instead of Mutex in MemoryRelationsStore and StagingRelationsStore * fix clippy warnings * fix simpa for low delay values * Improve delete_children n StagingRelationsStore * Suggestion for removing the need for `RefCell` (#4) * prep for ref-cell removal * remove ref-cell from StagingRelationsStore * remove ref-cell from MemoryRelationsStore * add comment * update comment * flatten staging (semantic change only) * unify deletions * use correct prefix * bug fix: add to child deletions even if not removed from insertions * remove unused API method * fix user msg * add simpa as test * Revert "Get rid of relations service" This reverts commit e8f61b1. * Revert "Remove relations rwlock" This reverts commit 0a4c5dd. * Remove redundant ChildKey * set access: - cache the new item only if the set entry already exists in the cache - fix bug in delete_bucket where set was emptied in cache but the entry was not removed * bug fix: make sure to propagate key not found err if staging has no data for this hash * clean * Remove redundant comment --------- Co-authored-by: Michael Sutton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.