Refactor p2p port handling #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the handling of default p2p port. Previously, a fixed port was being used which was not serving the purpose when the operator runs a node and specifies a non-standard local port. The revised code implements variable 'desired_external_port' to set the port number from the normalized peer-to-peer listening address. This allows the use of a non-standard public address. This change makes the system more adaptable to operator wishes and avoids potential conflicts.
michaelsutton
approved these changes
Nov 9, 2023
smartgoo
pushed a commit
to smartgoo/rusty-kaspa
that referenced
this pull request
Jun 18, 2024
Changed the handling of default p2p port. Previously, a fixed port was being used which was not serving the purpose when the operator runs a node and specifies a non-standard local port. The revised code implements variable 'desired_external_port' to set the port number from the normalized peer-to-peer listening address. This allows the use of a non-standard public address. This change makes the system more adaptable to operator wishes and avoids potential conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the handling of default p2p port. Previously, a fixed port was being used which was not serving the purpose when the operator runs a node and specifies a non-standard local port. The revised code implements variable 'desired_external_port' to set the port number from the normalized peer-to-peer listening address. This allows the use of a non-standard public address. This change makes the system more adaptable to operator wishes and avoids potential conflicts.