Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt wallet UTXO selection to dust patch #2254

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

michaelsutton
Copy link
Collaborator

Applies a fix to the wallet UTXO selection algorithm: if the created transaction has a change output (and thus 2 outputs overall), try having at least 2 inputs as well (in order to not be slowed down by dust patch).

Note that the auto-compound case does not require any adjustments. If the last tx in the compound op has a single input, there wouldn't be a need for the last level in the compound tree

…uts as well (in order to not be slowed down by dust patch)
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (8e71f79) 58.90% compared to head (ad1a49c) 58.89%.
Report is 2 commits behind head on dev.

Files Patch % Lines
cmd/kaspawallet/send.go 0.00% 14 Missing ⚠️
...allet/daemon/server/create_unsigned_transaction.go 0.00% 1 Missing ⚠️
.../consensus/processes/blockbuilder/block_builder.go 66.66% 0 Missing and 1 partial ⚠️
domain/miningmanager/mempool/mempool.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2254      +/-   ##
==========================================
- Coverage   58.90%   58.89%   -0.01%     
==========================================
  Files         679      679              
  Lines       33243    33243              
==========================================
- Hits        19582    19580       -2     
- Misses      10814    10817       +3     
+ Partials     2847     2846       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@someone235 someone235 merged commit 0819244 into kaspanet:dev Dec 25, 2023
5 checks passed
@michaelsutton michaelsutton deleted the wallet-utxo-selection branch December 25, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants