Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extract atomic swap data pushes #2203

Merged
merged 8 commits into from
Dec 11, 2023

Conversation

someone235
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (40ec440) 58.88% compared to head (f984070) 58.81%.
Report is 1 commits behind head on dev.

❗ Current head f984070 differs from pull request most recent head 0ab0e16. Consider uploading reports for the commit 0ab0e16 to get more accurate results

Files Patch % Lines
domain/consensus/utils/txscript/standard.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2203      +/-   ##
==========================================
- Coverage   58.88%   58.81%   -0.08%     
==========================================
  Files         679      679              
  Lines       33241    33121     -120     
==========================================
- Hits        19574    19480      -94     
+ Misses      10817    10796      -21     
+ Partials     2850     2845       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@someone235 someone235 merged commit 346341a into kaspanet:dev Dec 11, 2023
KashProtocol pushed a commit to Kash-Protocol/kashd that referenced this pull request Dec 17, 2023
* Remove unnecessary drop from ExtractAtomicSwapDataPushes

* fixed atomicswap 

fixed ExtractAtomicSwapDataPushes to extract the correct RefundBlake2b

* Fix message converters

* Fix locktime data size in ExtractAtomicSwapDataPushes

---------

Co-authored-by: pieroforfora <124444595+pieroforfora@users.noreply.github.com>
okilisan pushed a commit to okilisan/karlsend that referenced this pull request Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants