Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use openspout for Excel exports #381

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Use openspout for Excel exports #381

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
881ed0d
Use openspout for excel and CSV
chriscpty Jan 3, 2025
c44ab02
Use openspout for excel and CSV
chriscpty Jan 3, 2025
e846eb2
Use openspout for excel and CSV
chriscpty Jan 3, 2025
519f686
Use openspout for excel and CSV
chriscpty Jan 3, 2025
6fe312e
Use openspout for excel and CSV
chriscpty Jan 3, 2025
2f23417
Use openspout for excel and CSV
chriscpty Jan 3, 2025
53d6d5c
Use openspout for excel and CSV
chriscpty Jan 7, 2025
17ce93f
Use openspout for excel and CSV
chriscpty Jan 7, 2025
352164b
Use openspout for excel and CSV
chriscpty Jan 7, 2025
62e1e33
Use openspout for excel and CSV
chriscpty Jan 8, 2025
47e8211
Use openspout for excel and CSV
chriscpty Jan 8, 2025
366aac4
Use openspout for excel and CSV
chriscpty Jan 8, 2025
a8ca721
Use openspout for excel and CSV
chriscpty Jan 8, 2025
94ad90f
Use openspout for excel and CSV
chriscpty Jan 8, 2025
fb55c82
Use openspout for excel and CSV
chriscpty Jan 8, 2025
4b62dae
Use openspout for excel and CSV
chriscpty Jan 9, 2025
83cf507
Use openspout for excel and CSV
chriscpty Jan 10, 2025
c6f320b
Use openspout for excel and CSV
chriscpty Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/ExportMenu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1562,9 +1562,6 @@ public function generateBody()
$this->findGroupedColumn();
while (count($models) > 0) {
$keys = $this->_provider->getKeys();
if ($this->_provider instanceof ArrayDataProvider) {
$models = array_values($models);
}
foreach ($models as $index => $model) {
$key = $keys[$index];
$isLastRow = $index === $totalCount - 1;
chriscpty marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -1602,7 +1599,7 @@ public function generateBody()
$this->_provider->pagination->page++;
$this->_provider->refresh();
$this->_provider->setTotalCount($totalCount);
$models = $this->_provider->getModels();
$models = array_values($this->_provider->getModels());
chriscpty marked this conversation as resolved.
Show resolved Hide resolved
} else {
$models = [];
}
Expand Down
3 changes: 2 additions & 1 deletion src/messages/de/kvexport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
'The EXCEL 95+ (xls) export file will be generated for download.' => 'Die Excel 95+(xls)-Export-Datei wird für den Download erstellt.',
'The HTML export file will be generated for download.' => 'Die HTML-Export-Datei wird für den Download erstellt.',
'The PDF export file will be generated for download.' => 'Die PDF-Export-Datei wird für den Download erstellt.',
'The OPENOFFICE export file will be generated for download.' => 'Die Text-Export-Datei wird für den Download erstellt.',
'The TEXT export file will be generated for download.' => 'Die Text-Export-Datei wird für den Download erstellt.',
'The OPENOFFICE export file will be generated for download.' => 'Die OpenOffice-Export-Datei wird für den Download erstellt.',
'CSV' => '',
'Excel 2007+' => '',
'Excel 95 +' => '',
Expand Down