[patch] 2024.6 rc33 #662
Merged
[patch] 2024.6 rc33 #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handling for undocumented errors as per the docs,we can use either orderId or tracking number but order is better in case where we have multiple packages. in fact till now we send wrongly the orderId as the trackingId in the cancel request. testing with the api it turns out that the cancel request is not responding with the documented errors, it returns a status code 200 and just has error in the body
Eshipper fix cancel shipment request, and adding special error handling
… order cancellation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix
eshippercancel shipment request, and add special cancel error handling for undocumented errorseshipperdatetimerequirement for ship date and update tests for order cancellationfedextracking estimated delivery date response parsingeshipperforcarrier_name