Re enroll #4
Merged
Re enroll #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
byteZorvin
commented
Aug 1, 2024
byteZorvin
commented
- This adds the reactivate and unblock functionality for a token
- A token that has been active can be only be deactivated
- Only Unknown token can be blocked
- Adds relevant testcases
Co-authored-by: Apoorv Sadana <[email protected]>
apoorvsadana
reviewed
Aug 1, 2024
apoorvsadana
reviewed
Aug 1, 2024
tests/token_bridge_test.cairo
Outdated
| #[test] | ||
| fn unblock_token_ok() { | ||
| let mut mock = mock_state_testing(); | ||
| let usdc_address = deploy_erc20("usdc", "usdc"); |
There was a problem hiding this comment.
do we need to deploy a token?
There was a problem hiding this comment.
Oh ya makes sense, can mock an address to do so as well. Do you want me change this in this pr?
There was a problem hiding this comment.
yep, makes sense to do it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.