-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds karmadactl flags for proper display #763
Conversation
Signed-off-by: LavredisG <[email protected]>
A bit unrelated to the specific PR, but since it's on this page: What is the purpose of the metrics-adapter? I would suppose that it is needed in order to expose Karmada metrics, but I can't curl the :8080 port of the pod running the metrics server. However, I can scrape for example the karmada-controller pod to get metrics related to the controller instead. In addition to that, what is the purpose of the metrics-server? I can scrape karmada-controller for example even without them being installed on the member clusters and get info about each member cluster that has joined karmada. Concluding, what is the purpose of the metrics-adapter and metrics-server pods? |
cc @zhzhuang-zju Can you help to take a look? |
thanks @LavredisG |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zhzhuang-zju Can you help to open another PR to sync the zh docs? |
@LavredisG |
Thank you! In that case, in order to get metrics from the page of "Karmada Metrics Reference" do I have to scrape each target mentioned there that exports the metrics I need? Edit: After taking a look at an old PR, I guess that's how it's supposed to work, you scrape each target individually to get the metric you need. |
/kind documentation
Which issue(s) this PR fixes:
Fixes karmada-io/karmada#5915