Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds karmadactl flags for proper display #763

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

LavredisG
Copy link
Contributor

/kind documentation

Which issue(s) this PR fixes:
Fixes karmada-io/karmada#5915

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 13, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 13, 2024
@LavredisG
Copy link
Contributor Author

A bit unrelated to the specific PR, but since it's on this page:

What is the purpose of the metrics-adapter? I would suppose that it is needed in order to expose Karmada metrics, but I can't curl the :8080 port of the pod running the metrics server. However, I can scrape for example the karmada-controller pod to get metrics related to the controller instead.

In addition to that, what is the purpose of the metrics-server? I can scrape karmada-controller for example even without them being installed on the member clusters and get info about each member cluster that has joined karmada.

Concluding, what is the purpose of the metrics-adapter and metrics-server pods?

@RainbowMango
Copy link
Member

cc @zhzhuang-zju Can you help to take a look?

@zhzhuang-zju
Copy link
Contributor

thanks @LavredisG
/assign

@zhzhuang-zju
Copy link
Contributor

/lgtm
assign @RainbowMango

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@karmada-bot karmada-bot merged commit ce1468d into karmada-io:main Dec 16, 2024
7 checks passed
@RainbowMango
Copy link
Member

@zhzhuang-zju Can you help to open another PR to sync the zh docs?

@RainbowMango
Copy link
Member

Concluding, what is the purpose of the metrics-adapter and metrics-server pods?

@LavredisG
The metrics-server running on member clusters, is used to expose metrics of Kubernetes so that Karmada can grab metrics from it.
The karmada-metrics-adapter is used to collect metrics of Kubernetes, and then aggregate the metrics for global HPA purposes.

@LavredisG
Copy link
Contributor Author

LavredisG commented Dec 16, 2024

Concluding, what is the purpose of the metrics-adapter and metrics-server pods?

@LavredisG The metrics-server running on member clusters, is used to expose metrics of Kubernetes so that Karmada can grab metrics from it. The karmada-metrics-adapter is used to collect metrics of Kubernetes, and then aggregate the metrics for global HPA purposes.

Thank you! In that case, in order to get metrics from the page of "Karmada Metrics Reference" do I have to scrape each target mentioned there that exports the metrics I need?

Edit: After taking a look at an old PR, I guess that's how it's supposed to work, you scrape each target individually to get the metric you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Karmadactl incosistent displays
4 participants