remove beta apiversion #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @sashalarsoo! It looks like this is your first PR to karmada-io/website 🎉 |
karmada-bot
added
the
size/S
Signed-off-by: Sasha Larsonneur <[email protected]>
sashalarsoo
force-pushed
the
remove-beta-apiversion
branch
from
41f0e5d to
89efbe7
Compare
|
/retest |
karmada-bot
added
size/M
Signed-off-by: RainbowMango <[email protected]>
RainbowMango
force-pushed
the
remove-beta-apiversion
branch
from
2328697 to
b77db98
Compare
karmada-bot
added
size/L
|
@sashalarsoo Thanks for doing this. cc @chaosi-zju |
|
/assign |
|
Let's move this forward. @chaosi-zju If you have any further comments, please cc me. |
RainbowMango
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
After test, it seems helm deployment with fluxcd is not working due to the apiversion of "helmrepository" or "helmrelease".
Just removed the beta in the api version and worked !