Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics #424

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Update metrics #424

merged 1 commit into from
Jul 19, 2023

Conversation

Poor12
Copy link
Member

@Poor12 Poor12 commented Jul 18, 2023

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Update metrics doc. Ref: karmada-io/karmada#3795

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
@jwcesign

Signed-off-by: Poor12 <[email protected]>
@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 18, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @jwcesign

@jwcesign
Copy link
Member

/lgtm

But we need to improve this document, I create an issue to follow this #425

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@karmada-bot karmada-bot merged commit 1f9bbf7 into karmada-io:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants