Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CK2Transcript #69

Open
wants to merge 15 commits into
base: v2.x-beta
Choose a base branch
from
Open

CK2Transcript #69

wants to merge 15 commits into from

Conversation

mikeabdullah
Copy link
Collaborator

Starting a draft up of how CK's transcript support could be better encapsulated

@mikeabdullah
Copy link
Collaborator Author

So I'd say one downside of how this currently stands: The transcript is shared between all file managers, and never cleared by default. This could lead to quite a buildup of memory. Couple of options:

  • Transcript could be left out by default; clients then explicitly hook one up if they're interested
  • By default all file managers create their own transcript which is then (likely) deallocated when they are, keeping overhead low

Either way, what suits Sandvox best at present is a single shared transcript, but likely in the future I want to move toward one transcript per document.

I think I favour the first option more; it has the lowest overhead and can be neatly specified by some sort of CK2Configuration object passed into the file manager at creation time (i.e. ripping off NSURLSession once again).

@MrNoodle
Copy link
Contributor

I just need one shared transcript as well so I'm fine with whatever as long as that use case remains easy to do. I guess that would make option 1 more desirable in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants