Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix number of download threads reportedly being 1 on some machines regardless of the configuration #253

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

leoisl
Copy link
Collaborator

@leoisl leoisl commented Dec 14, 2023

This PR fixes number of download threads reportedly being 1 on some machines regardless of the configuration.
It worked on EBI slurm cluster, please test in your before merging.

Closes #242

Note 1: I had to remove -p priority when submitting the slurm job as this queue does not exist in EBI slurm cluster so I think is not standard;
Note 2: why not tell snakemake to use the user's slurm profile and let it deal with it, like we do for the lsf profile?

@leoisl leoisl requested a review from karel-brinda December 14, 2023 14:37
@karel-brinda
Copy link
Owner

Thank you very much for the fix!!

Re Note 2: We should discuss this in a separate issue. I have never used slurm profiles so I'm unable to tell anything. The slurm command was mainly an adhoc thing for the Harvard O2 cluster (and this cluster requires a queue specification).

@karel-brinda karel-brinda merged commit c6e3d71 into karel-brinda:main Dec 14, 2023
8 checks passed
@leoisl leoisl deleted the fix/242 branch December 15, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of download threads reportedly being 1 on some machines regardless of the configuration
2 participants