Fix/236 (fix Zenodo blocking downloads) #247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in this PR is dealing with Zenodo blocking downloads (see #236 for details). This is solved by adding a random sleep time between 0 and (attempt-1) minutes (or 0 and (attempt-1)*60 seconds) and retrying the download for up to 3 times.
Two tests in the EBI cluster succeeded, where Zenodo always blocks downloads after some time. In the first test, Zenodo blocked 85 downloads but the retries were successful. In the second test, 71 downloads were blocked but the retries were also successful. As such I think this PR solves this issue and closes #236.
As a secondary change, this PR also contains some refactor to the download code.