Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples #31

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Update examples #31

merged 2 commits into from
Feb 1, 2025

Conversation

kapi2289
Copy link
Owner

@kapi2289 kapi2289 commented Jan 8, 2025

After some testing, I've come up with an easier to understand and maintain vite.config.js configuration, which is also closer to the default Laravel usage.

@adrum, as you have proposed the previous examples, I would appreciate an opinion on it. Thanks in advance.

@kapi2289 kapi2289 added the documentation Improvements or additions to documentation label Jan 8, 2025
@adrum
Copy link
Contributor

adrum commented Jan 11, 2025

@kapi2289 It seems like to me this would forgo the ClientApp directory, and just move everything inside of that directory up one level. Is that correct? This would feel like an anti-pattern for .NET projects, if so.

I do like the simpler setup inside the vite config, but I wonder if we need to describe the setup with a bit more detail.

@kapi2289
Copy link
Owner Author

@adrum Take a look at the examples now. I've tested it with a ClientApp structure, and it works for me.

@adrum
Copy link
Contributor

adrum commented Jan 15, 2025

@kapi2289 Looks good to me! Much more simple.

@kapi2289 kapi2289 merged commit 3ab22e2 into v1 Feb 1, 2025
1 check failed
@kapi2289 kapi2289 deleted the readme-examples branch February 1, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants