Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled misspel linter for test package #3052

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

anishbista60
Copy link
Contributor

@anishbista60 anishbista60 commented Aug 21, 2024

Change Overview

  • Removed the linter misspell

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@anishbista60
Copy link
Contributor Author

@julio-lopez @saima-s All changes looks fine here , as i test in my local .
Except below three.

pkg/secrets/repositoryserver/aws_secrets_test.go:19: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/kanisterio/kanister) -s blank -s dot (gci)

pkg/secrets/repositoryserver/azure_secrets_test.go:19: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/kanisterio/kanister) -s blank -s dot (gci)

pkg/secrets/repositoryserver/gcp_secrets_test.go:19: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/kanisterio/kanister) -s blank -s dot (gci)

what is missing here? i have arranged these package based on
https://github.com/kanisterio/kanister/blob/adab42bfd592f034ece0a3b9595218b87eb84d0f/.golangci.yml#L77

Copy link
Contributor

@julio-lopez julio-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the import changes need to be reverted as well.
The original ordering was correct.

It seems that the . import is throwing off gci.

pkg/secrets/repositoryserver/azure_secrets_test.go Outdated Show resolved Hide resolved
pkg/secrets/repositoryserver/aws_secrets_test.go Outdated Show resolved Hide resolved
pkg/secrets/repositoryserver/gcp_secrets_test.go Outdated Show resolved Hide resolved
pkg/secrets/repositoryserver/s3compliant_secrets_test.go Outdated Show resolved Hide resolved
@anishbista60 anishbista60 changed the title Removed the linter - misspel & gci Removed the linter - misspel Aug 24, 2024
@anishbista60
Copy link
Contributor Author

@julio-lopez i think i should have next PR for gci.

@julio-lopez julio-lopez merged commit 6f6a21e into kanisterio:master Aug 24, 2024
16 checks passed
@anishbista60 anishbista60 changed the title Removed the linter - misspel Enabled misspel linter for test package Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants