SUP-46065: Player shows VR button based on "360" (or variations) tag #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yambenari24
requested review from
SivanA-Kaltura,
MosheMaorKaltura,
lianbenjamin and
semarche-kaltura
src/k-provider/ovp/provider.ts
Outdated
| Object.assign(sourcesObject.metadata, mediaEntry.metadata); | ||
| return sourcesObject; | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/explicit-function-return-type | ||
| public _updatePlayerVrPluginIsOn(vrTag: string) { |
src/k-provider/ovp/provider.ts
Outdated
| } | ||
|
|
||
| if(this._vrPluginIsOn && this._vrTag) | ||
| if (mediaEntry.metadata && typeof mediaEntry.metadata.tags === 'string' && mediaEntry.metadata.tags.split(', ').includes(this._vrTag)) { |
There was a problem hiding this comment.
split by "," and trim the value before checking includes
src/k-provider/ovp/provider.ts
Outdated
| sourcesObject.vr = {}; | ||
| } | ||
|
|
||
| if(this._vrPluginIsOn && this._vrTag) |
There was a problem hiding this comment.
this._vrPluginIsOn is not needed
| sourcesObject.vr = {}; | ||
|
|
||
| if(this._vrTag) { | ||
| if (mediaEntry.metadata && typeof mediaEntry.metadata.tags === 'string' && mediaEntry.metadata.tags.split(',').map(tag => tag.trim().includes(this._vrTag))) { |
There was a problem hiding this comment.
use some instead of map, as one good tag is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:
360 tag is being concat and playing 360VR video when no needed.
fix:
support new feature: add to the configuration a tag in the vr plugin, and compare it to the metadata tags of the entry.
Tag is being transferred using the player, which transfer it to the provider.
kaltura/kaltura-player-js#915
kaltura/playkit-js-vr#110
solved:
SUP-46065