fix(FEC-14289): Player v7 | Player doesn't recover well after network disconnection #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeedean
changed the title
SivanA-Kaltura
requested changes
Feb 2, 2025
| */ | ||
| function createKalturaPlayerContainer(targetId: string): string { | ||
| function createKalturaPlayerContainer(options: PartialKPOptionsObject): string { |
There was a problem hiding this comment.
can you explain why this was needed ?
There was a problem hiding this comment.
before destroying the old player we save his config.
when we are doing player.setup again after destroying the old player, we need access to the "options.ui.targetId" from the config.
we are creating a new player with the same config as the old one, so we need is element id to be the same.
if we won't use the old element id "options.ui.targetId", it will create the new player with unmatched element id which will cause errors later in the process of the player.setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
After player had network disconnection error and user clicked on 'Try Again', player should be destroyed and we should setup a new player before using loadMedia.
Related PR: kaltura/playkit-js-ui#978
Resolves FEC-14289