Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storagenode): remove package internal/batchlet #967

Open
wants to merge 1 commit into
base: refactor_logstream_deprecate_old_replicatetask_pool_management
Choose a base branch
from

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Jan 21, 2025

What this PR does

This PR removes the package internal/batchlet that is kind of small batch. Thus
batch in Append RPC message is not splitted any more.

@ijsong ijsong requested a review from hungryjang as a code owner January 21, 2025 12:24
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.01%. Comparing base (7f3f55b) to head (647cba4).

Files with missing lines Patch % Lines
internal/storagenode/logstream/append.go 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                        Coverage Diff                                         @@
##           refactor_logstream_deprecate_old_replicatetask_pool_management     #967      +/-   ##
==================================================================================================
- Coverage                                                           80.20%   80.01%   -0.19%     
==================================================================================================
  Files                                                                 179      178       -1     
  Lines                                                               21592    21509      -83     
==================================================================================================
- Hits                                                                17317    17211     -106     
- Misses                                                               3490     3504      +14     
- Partials                                                              785      794       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong ijsong force-pushed the refactor_sn_no_batchlet_in_append branch from 485f6c6 to fc7d431 Compare January 23, 2025 12:09
Copy link
Member

@hungryjang hungryjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice to be more concise.

@ijsong ijsong force-pushed the refactor_logstream_deprecate_old_replicatetask_pool_management branch from daf76e3 to b43dd94 Compare February 3, 2025 10:58
@ijsong ijsong force-pushed the refactor_sn_no_batchlet_in_append branch from fc7d431 to 2e40f11 Compare February 3, 2025 10:58
This PR removes the package internal/batchlet that is kind of small batch. Thus
batch in Append RPC message is not splitted any more.
@ijsong ijsong force-pushed the refactor_logstream_deprecate_old_replicatetask_pool_management branch from b43dd94 to 7f3f55b Compare February 3, 2025 11:25
@ijsong ijsong force-pushed the refactor_sn_no_batchlet_in_append branch from 2e40f11 to 647cba4 Compare February 3, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants