refactor: Remove unnecessary code from proto/varlogpb/log_entry.go #927
+302
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #927 +/- ##
=======================================
Coverage 79.08% 79.09%
=======================================
Files 180 179 -1
Lines 21615 21607 -8
=======================================
- Hits 17094 17089 -5
+ Misses 3711 3695 -16
- Partials 810 823 +13 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
tests_for_syncposition_and_syncrange
branch
from
4499f90 to
9ab27cb
Compare
ijsong
force-pushed
the
refactor_remove_unnecessary_code_from_proto_varlogpb_log_entry
branch
from
382277e to
a62e2db
Compare
ijsong
force-pushed
the
tests_for_syncposition_and_syncrange
branch
from
9ab27cb to
c734a48
Compare
ijsong
force-pushed
the
refactor_remove_unnecessary_code_from_proto_varlogpb_log_entry
branch
from
a62e2db to
1001a00
Compare
ijsong
force-pushed
the
tests_for_syncposition_and_syncrange
branch
from
c734a48 to
21de96f
Compare
ijsong
force-pushed
the
refactor_remove_unnecessary_code_from_proto_varlogpb_log_entry
branch
from
1001a00 to
eceacfe
Compare
hungryjang
reviewed
Feb 1, 2025
hungryjang
approved these changes
Feb 3, 2025
ijsong
force-pushed
the
tests_for_syncposition_and_syncrange
branch
from
21de96f to
954578f
Compare
ijsong
force-pushed
the
refactor_remove_unnecessary_code_from_proto_varlogpb_log_entry
branch
from
eceacfe to
fc9386d
Compare
- Add tests for StorageNodeMetadataDescriptor and LogStreamReplicaMetadataDescriptor - Test methods: ToStorageNodeDescriptor, GetLogStream, Head, and Tail - Ensure proper coverage for edge cases and nil values
- Add comments for SyncPosition.InvalidSyncPosition, SyncPosition.Invalid, SyncPosition.LessThan, SyncRange.InvalidSyncRange, and SyncRange.Validate methods. - Add unit tests for SyncRange validation and invalid cases.
- replaced InvalidLogEntry with an empty LogEntry across the codebase - removed proto/varlogpb/log_entry.go as it contained unused code - updated related files to reflect these changes
ijsong
force-pushed
the
tests_for_syncposition_and_syncrange
branch
from
954578f to
a037220
Compare
ijsong
force-pushed
the
refactor_remove_unnecessary_code_from_proto_varlogpb_log_entry
branch
from
fc9386d to
78f315c
Compare
ijsong
deleted the
refactor_remove_unnecessary_code_from_proto_varlogpb_log_entry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does