feat: task 5, import and parse csv file #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshynkarenko
approved these changes
Apr 10, 2024
Comment on lines
+25
to
+38
| This template contains a single lambda function triggered by an HTTP request made on the provisioned API Gateway REST API `/hello` route with `POST` method. The request body must be provided as `application/json`. The body structure is tested by API Gateway against `src/functions/hello/schema.ts` JSON-Schema definition: it must contain the `name` property. | ||
|
|
||
| - requesting any other path than `/hello` with any other method than `POST` will result in API Gateway returning a `403` HTTP error code | ||
| - sending a `POST` request to `/hello` with a payload **not** containing a string property named `name` will result in API Gateway returning a `400` HTTP error code | ||
| - sending a `POST` request to `/hello` with a payload containing a string property named `name` will result in API Gateway returning a `200` HTTP status code with a message saluting the provided name and the detailed event processed by the lambda | ||
|
|
||
| > :warning: As is, this template, once deployed, opens a **public** endpoint within your AWS account resources. Anybody with the URL can actively execute the API Gateway endpoint and the corresponding lambda. You should protect this endpoint with the authentication method of your choice. | ||
| ### Locally | ||
|
|
||
| In order to test the hello function locally, run the following command: | ||
|
|
||
| - `npx sls invoke local -f hello --path src/functions/hello/mock.json` if you're using NPM | ||
| - `yarn sls invoke local -f hello --path src/functions/hello/mock.json` if you're using Yarn |
There was a problem hiding this comment.
could be good to have this part updated with actual samples
| statusCode: 200, | ||
| body: JSON.stringify(SIGNED_URL), | ||
| })); | ||
| }); |
There was a problem hiding this comment.
would be good to also cover error scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoints:
GET - https://0e86mwnks8.execute-api.eu-central-1.amazonaws.com/dev/import?name=${file_name.csv}
Frontend: https://di3lwshdkkn9h.cloudfront.net/
Frontend PR: k4v1cs/shop-angular-cloudfront#3
Additional scope: